[ 
https://issues.apache.org/jira/browse/ORC-9?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14642907#comment-14642907
 ] 

ASF GitHub Bot commented on ORC-9:
----------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/5#discussion_r35551926
  
    --- Diff: c++/src/Reader.cc ---
    @@ -993,12 +995,25 @@ namespace orc {
         }
       }
     
    +  int64_t getEpochOffset() {
    +    struct tm epoch;
    +    epoch.tm_sec = 0;
    +    epoch.tm_min = 0;
    +    epoch.tm_hour = 0;
    +    epoch.tm_mday = 1;
    +    epoch.tm_mon = 0;
    +    epoch.tm_year = 2015 - 1900;
    +    epoch.tm_isdst = 0;
    +    return static_cast<int64_t>(mktime(&epoch));
    +  }
    +
    --- End diff --
    
    I guess I should add a comment saying that :).


> Create a ColumnVectorBatch for Timestamps
> -----------------------------------------
>
>                 Key: ORC-9
>                 URL: https://issues.apache.org/jira/browse/ORC-9
>             Project: Orc
>          Issue Type: Bug
>          Components: C++, encoding
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> Create a TimestampVectorBatch that uses time_t and the number of nanoseconds.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to