[
https://issues.apache.org/jira/browse/ORC-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107190#comment-15107190
]
ASF GitHub Bot commented on ORC-8:
----------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/15#discussion_r50155968
--- Diff: tools/src/FileMetadata.cc ---
@@ -16,168 +16,162 @@
* limitations under the License.
*/
+#include <getopt.h>
#include <iostream>
#include <fstream>
#include <vector>
#include <string>
#include <sstream>
-#include <iomanip>
-#include "wrap/orc-proto-wrapper.hh"
#include "orc/OrcFile.hh"
-using namespace orc::proto;
-
-uint64_t getTotalPaddingSize(const Footer& footer) {
- uint64_t paddedBytes = 0;
- StripeInformation stripe;
- for (int stripeIx=1; stripeIx<footer.stripes_size(); stripeIx++) {
- stripe = footer.stripes(stripeIx-1);
- uint64_t prevStripeOffset = stripe.offset();
- uint64_t prevStripeLen = stripe.datalength() + stripe.indexlength() +
- stripe.footerlength();
- paddedBytes += footer.stripes(stripeIx).offset() -
- (prevStripeOffset + prevStripeLen);
- };
- return paddedBytes;
+void printStripeInformation(std::ostream& out,
+ uint64_t index,
+ uint64_t columns,
+ std::unique_ptr<orc::StripeInformation> stripe,
+ bool verbose) {
+ out << " { \"stripe\": " << index
+ << ", \"rows\": " << stripe->getNumberOfRows() << ",\n";
+ out << " \"offset\": " << stripe->getOffset()
+ << ", \"length\": " << stripe->getLength() << ",\n";
--- End diff --
The lines get really long and hard to read. I don't think we should merge
those lines. I've grouped related fields together on to the same line.
> Replace tool implementation to use Reader interface
> ---------------------------------------------------
>
> Key: ORC-8
> URL: https://issues.apache.org/jira/browse/ORC-8
> Project: Orc
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
>
> Currently FileMetadata is using custom parsing of the ORC footer and
> postscript. It should use the standard interface from Reader.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
