[
https://issues.apache.org/jira/browse/ORC-10?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158361#comment-15158361
]
ASF GitHub Bot commented on ORC-10:
-----------------------------------
GitHub user omalley opened a pull request:
https://github.com/apache/orc/pull/18
ORC-10. Correct bug when moving ORC files between timezones.
This patch:
* Create the new Timezone class that reads the tzfiles and interprets
them.
* Changes the timestamp reader to use the writer's timezone if the writer
included it.
* Changes the timestamp column vector representation to UTC so that we
don't need to do a second lookup and translation into the local timezone.
* ColumnPrinter is changed to assume the column vector is in UTC.
* Makes the test for >2038 support explicitly set the timezone.
* Adds variables for the run-all.sh docker script that lets you change
the repository and branch to test.
* Removes a spurious -O0 from the tools' cmake file.
I've tested this patch on MacOS 10.11 and all of the docker scripts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omalley/orc orc-10
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/18.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18
----
commit 6dce746c30098a7b708dfa0aa5010260fd505ca6
Author: Owen O'Malley <[email protected]>
Date: 2016-02-11T23:21:03Z
ORC-10. Correct bug when moving ORC files between timezones.
----
> Fix timestamp moving between timezones (HIVE-8746 in C++)
> ---------------------------------------------------------
>
> Key: ORC-10
> URL: https://issues.apache.org/jira/browse/ORC-10
> Project: Orc
> Issue Type: Bug
> Components: C++, encoding
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Fix For: 1.1.0
>
>
> ORC stores the difference from an epoch in the local timezone. That makes ORC
> mostly resilient when moving between timezones, but fails when moving between
> timezones with different daylight savings rules.
> ORC currently stores the timezone information in the stripe footer, so that
> the reader can understand the times correctly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
