[
https://issues.apache.org/jira/browse/ORC-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230806#comment-15230806
]
ASF GitHub Bot commented on ORC-46:
-----------------------------------
Github user omalley commented on the pull request:
https://github.com/apache/orc/pull/20#issuecomment-207046601
A couple of thoughts:
* So Presto has a writer now? If so, we should extend the WriterVersion
with a new id for it so that we can handle bugs that are specific to that
implementation.
* I assume you'll follow the same compression block structure that we used
with zlib and snappy. (Three bytes of header followed by the untagged
compressed bytes.) I'm very concerned that we don't break compatibility with
the C++ and Java readers.
* That is *really* cool that there is a pure Java LZO, Snappy, and LZ4
implementation that is Apache licensed. Does it have a release that is pushed
to Maven central?
> Reserve CompressionKind values for LZ4 and ZSTD
> -----------------------------------------------
>
> Key: ORC-46
> URL: https://issues.apache.org/jira/browse/ORC-46
> Project: Orc
> Issue Type: Improvement
> Reporter: David Phillips
>
> We are going to start using ORC with LZ4 and ZSTD compression types in Presto
> (which has its own reader and soon its own writer). Registering these as
> official CompressionKind values now will avoid future compatibility issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
