[
https://issues.apache.org/jira/browse/ORC-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338945#comment-15338945
]
ASF GitHub Bot commented on ORC-58:
-----------------------------------
GitHub user majetideepak opened a pull request:
https://github.com/apache/orc/pull/41
ORC-58: Move code for reading rows from Reader to RowReader
This PR divides the current Reader class into Reader class and RowReader
class
Reader class reads the footer and metadata from an ORC file.
RowReader class reads the rows from the file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/majetideepak/orc RowReader
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/41.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #41
----
commit ed02d7ab668c1a61f8260e0efddf06c617658753
Author: Deepak Majeti <[email protected]>
Date: 2016-06-05T21:51:45Z
Split curent Reader into RowReader and Reader
----
> Move code for reading rows from Reader to RowReader
> ---------------------------------------------------
>
> Key: ORC-58
> URL: https://issues.apache.org/jira/browse/ORC-58
> Project: Orc
> Issue Type: Improvement
> Components: C++
> Reporter: Deepak Majeti
>
> Existing ReaderImpl constructor can throw an exception. This prohibits the
> creation of the reader instance and subsequent access to the schema
> information.
> For instance, an exception can be thrown if the selected column ids do not
> agree with the number of schema columns. The downstream application might
> still want the schema information for logging purposes.
> The scope of this Jira is to move the code to read rows into a new RowReader
> class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
