[
https://issues.apache.org/jira/browse/ORC-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429980#comment-15429980
]
Chunyang Wen edited comment on ORC-92 at 8/22/16 3:02 AM:
----------------------------------------------------------
omalley, I think your implementation has some problem.
1. includeTypes does Not select sub-types
2. selectParents may stop early, so that some sub-types may not be selected
when building columnvector.
e.g.
{code}
<a(1):int,
b(2):double,
c(3):struct<
c20(4):int,
c21(5):double
c22(6):struct<
d0(7):int,
d1(8):double>>>
{code}
number after field name is its column id.
if we select type: 3,4,8, then 5 is not selected. It is wrong because
selectParents will return when it meets 3.
was (Author: chunyang-wen):
omalley, I think your implementation has some problem.
1. includeTypes does Not select sub-types
2. selectParents may stop early, so that some sub-types may not be selected
when building columnvector.
e.g.
{code}
<a(1):int,
b(2):double,
c(3):struct<
c20(4):int,
c21(5):doulbe
c22(6):struct<
d0(7):int,
d1(8):double>>>
{code}
number after field name is its column id.
if we select type: 3,4,8, then 5 is not selected. It is wrong because
selectParents will return when it meets 3.
> Support column id and column name selection in ReaderOptions
> ------------------------------------------------------------
>
> Key: ORC-92
> URL: https://issues.apache.org/jira/browse/ORC-92
> Project: Orc
> Issue Type: New Feature
> Components: C++
> Affects Versions: 1.2.0
> Reporter: Chunyang Wen
> Assignee: Chunyang Wen
> Priority: Minor
> Fix For: 1.2.0
>
>
> Currently, in C++ version of orc. We can only select by filed id or field
> name. This works fine when data structure is flat such as struct<int1:int,
> s1:string, list1:array<int>>. But when we have a nested structure,
> struct<int1:int, struct1:struct<int2:int, long2:long>>. We still can only
> select the field of int1 and struct1. We can not directly select long2.
> We can select long2 by its column id. This can be achieved by updating
> include function in ReaderOptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
