[ 
https://issues.apache.org/jira/browse/ORC-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514211#comment-15514211
 ] 

ASF GitHub Bot commented on ORC-101:
------------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/60#discussion_r80114710
  
    --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java ---
    @@ -1168,8 +1193,9 @@ public OrcIndex readRowIndex(int stripeIndex, 
boolean[] included,
           sargColumns = sargColumns == null ?
               (sargApp == null ? null : sargApp.sargColumns) : sargColumns;
         }
    -    return dataReader.readRowIndex(stripe, stripeFooter, included, 
indexes, sargColumns,
    -        bloomFilterIndex);
    +    return dataReader.readRowIndex(stripe, evolution.getFileType(0), 
stripeFooter,
    --- End diff --
    
    Actually RecordReaderImpl.mapSargColumnsToOrcInternalColIdx already maps 
column names to the physical file column ids. It handles ACID files by looking 
for the field names in row field instead of the root. So at this level, it 
should be consistently using the file id.


> Correct the use of the default charset in the bloomfilter
> ---------------------------------------------------------
>
>                 Key: ORC-101
>                 URL: https://issues.apache.org/jira/browse/ORC-101
>             Project: Orc
>          Issue Type: Improvement
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>
> Currently ORC's bloom filter depends on the default character set, which 
> isn't constant between computers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to