[ https://issues.apache.org/jira/browse/ORC-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895676#comment-15895676 ]
ASF GitHub Bot commented on ORC-148: ------------------------------------ Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/99#discussion_r104287854 --- Diff: java/core/src/java/org/apache/orc/impl/RecordReaderImpl.java --- @@ -468,16 +470,15 @@ static TruthValue evaluatePredicateRange(PredicateLeaf predicate, Object min, } // in case failed conversion, return the default YES_NO_NULL truth value } catch (Exception e) { - if (LOG.isWarnEnabled()) { + if (LOG.isDebugEnabled()) { --- End diff -- This isn't ok. We can't take exceptions and make them invisible. We need to avoid the exception. > Move ORC PPD failure messages from WARN to DEBUG level > ------------------------------------------------------ > > Key: ORC-148 > URL: https://issues.apache.org/jira/browse/ORC-148 > Project: ORC > Issue Type: Bug > Affects Versions: 1.4.0 > Reporter: Prasanth Jayachandran > Assignee: Prasanth Jayachandran > Priority: Blocker > > Bunch of warn messages about skipping ORC PPD gets printed. This happens for > every stripe and every row group. Either we should print this once or move > this to DEBUG level > {code} > 2017-02-14T17:42:06,665 WARN [IO-Elevator-Thread-8 > (1484282558103_6753_2_05_000030_2)] impl.RecordReaderImpl: > IllegalStateException when evaluating predicate. Skipping ORC PPD. Exception: > Failed to retrieve dynamic value for RS_19_store_ss_store_sk_min StatsType: > Long PredicateType: null > 2017-02-14T17:42:06,665 WARN [IO-Elevator-Thread-3 > (1484282558103_6753_2_05_000057_0)] impl.RecordReaderImpl: > IllegalStateException when evaluating predicate. Skipping ORC PPD. Exception: > Failed to retrieve dynamic value for RS_19_store_ss_store_sk_min StatsType: > Long PredicateType: null > 2017-02-14T17:42:06,665 WARN [IO-Elevator-Thread-8 > (1484282558103_6753_2_05_000030_2)] impl.RecordReaderImpl: > IllegalStateException when evaluating predicate. Skipping ORC PPD. Exception: > Failed to retrieve dynamic value for RS_13_item_ss_item_sk_min StatsType: > Long PredicateType: null > 2017-02-14T17:42:06,665 WARN [IO-Elevator-Thread-3 > (1484282558103_6753_2_05_000057_0)] impl.RecordReaderImpl: > IllegalStateException when evaluating predicate. Skipping ORC PPD. Exception: > Failed to retrieve dynamic value for RS_13_item_ss_item_sk_min StatsType: > Long PredicateType: null > 2017-02-14T17:42:06,665 WARN [IO-Elevator-Thread-8 > (1484282558103_6753_2_05_000030_2)] impl.RecordReaderImpl: > IllegalStateException when evaluating predicate. Skipping ORC PPD. Exception: > Failed to retrieve dynamic value for RS_19_store_ss_store_sk_min StatsType: > Long PredicateType: null > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)