[
https://issues.apache.org/jira/browse/ORC-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983565#comment-15983565
]
ASF GitHub Bot commented on ORC-87:
-----------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/110#discussion_r113300916
--- Diff: c++/src/Statistics.cc ---
@@ -279,20 +277,28 @@ namespace orc {
}
TimestampColumnStatisticsImpl::TimestampColumnStatisticsImpl
- (const proto::ColumnStatistics& pb, bool correctStats) {
+ (const proto::ColumnStatistics& pb, const StatContext& statContext) {
valueCount = pb.numberofvalues();
- if (!pb.has_timestampstatistics() || !correctStats) {
+ if (!pb.has_timestampstatistics() || !statContext.correctStats) {
_hasMinimum = false;
_hasMaximum = false;
minimum = 0;
maximum = 0;
}else{
const proto::TimestampStatistics& stats = pb.timestampstatistics();
- _hasMinimum = stats.has_minimum();
- _hasMaximum = stats.has_maximum();
-
- minimum = stats.minimum();
- maximum = stats.maximum();
+ _hasMinimum = stats.has_minimumutc() || (stats.has_minimum() &&
statContext.writerTimezone);
+ _hasMaximum = stats.has_maximumutc() || (stats.has_maximum() &&
statContext.writerTimezone);
+
+ if (stats.has_minimumutc()) {
+ minimum = stats.minimumutc();
+ } else {
+ minimum = stats.minimum() + statContext.writerTimezone->getEpoch();
+ }
+ if (stats.has_minimumutc()) {
--- End diff --
You mean has_maximumutc() here.
> [C++] Handle missing timezone conversion for timestamp statistics
> -----------------------------------------------------------------
>
> Key: ORC-87
> URL: https://issues.apache.org/jira/browse/ORC-87
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> The recent release adds timezone to timestamp values but does not add the
> conversion for timestamp statistics.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
