[
https://issues.apache.org/jira/browse/ORC-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15995263#comment-15995263
]
ASF GitHub Bot commented on ORC-183:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/115#discussion_r114602179
--- Diff: c++/include/orc/Type.hh ---
@@ -82,6 +82,11 @@ namespace orc {
* @return a reference to the union type
*/
virtual Type* addUnionChild(ORC_UNIQUE_PTR<Type> fieldType) = 0;
+
+ /**
+ * Build a Type object from string text representation.
+ */
+ static Type* buildTypeFromString(const std::string& input);
--- End diff --
Let's make it a unique_ptr<Type> to make it clear that the caller owns the
pointer.
> [C++] Add a method in Type to build type from string
> ----------------------------------------------------
>
> Key: ORC-183
> URL: https://issues.apache.org/jira/browse/ORC-183
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> Currently Type class only supports building type like a container. It will be
> much easier to create type from a string.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
