[
https://issues.apache.org/jira/browse/ORC-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100895#comment-16100895
]
Owen O'Malley commented on ORC-218:
-----------------------------------
Which environment restricts the number of system calls like that?
Effectively, you are copying the TZ database into each executable so the bytes
will still be read when the executable is loaded. I want to understand the
context where this is useful.
> [C++] Cache timezone information in the library.
> ------------------------------------------------
>
> Key: ORC-218
> URL: https://issues.apache.org/jira/browse/ORC-218
> Project: ORC
> Issue Type: Improvement
> Reporter: Martin Grund
>
> Right now, for every lookup of a timezone, the library will go to disk and
> parse the timezone file. While the results are cached, doing these system
> calls should be avoided in environments with restricted system calls.
> I prepared a patch that will at build time load all the time zone files into
> the binary and instead of accessing disk for the TZ information will simply
> load the buffer from memory. In addition this allows the user to compile the
> library with a static timezone to be assumed for local use. This comes in
> handy to avoid yet another set of system calls to assume the local timezone.
> The feature can be controlled using the following CMake flags
> * NO_EMBEDED_TZ_DB - to turn it off, by default is on
> * STATIC_TZ=VAL - where val is a name of a timezone.
> I'll create a PR for code-review.
> Would be great if you could consider this patch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
