[
https://issues.apache.org/jira/browse/ORC-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117105#comment-16117105
]
ASF GitHub Bot commented on ORC-178:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/128#discussion_r131739382
--- Diff: c++/src/Vector.cc ---
@@ -35,6 +35,7 @@ namespace orc {
hasNulls(false),
memoryPool(pool) {
// PASS
--- End diff --
I was using "// PASS" to mean it was intentionally empty. Since you added a
statement, you should remove the comment also.
> Implement Basic C++ Writer and Writer Option
> --------------------------------------------
>
> Key: ORC-178
> URL: https://issues.apache.org/jira/browse/ORC-178
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Xiening Dai
>
> 1. write orc file header, file footer, postscript, etc.
> 2. write columns of all types
> 3. write column statistics
> 4. write index stream in writer and reader seeks to row based on index
> information
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
