[
https://issues.apache.org/jira/browse/ORC-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117110#comment-16117110
]
ASF GitHub Bot commented on ORC-218:
------------------------------------
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/142
You may find the docker scripts useful for testing in other linux platforms.
.. Owen
On Mon, Aug 7, 2017 at 10:06 AM, Martin Grund <[email protected]>
wrote:
> There's some funky stuff that's going on with the way how the code get's
> compiled in Travis, that I need to reproduce. The unit tests with the same
> combination of parameters works for me locally. Still working on it.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/orc/pull/142#issuecomment-320721828>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AAMmyICAV0Gst3DO2iVUUY4Bn_KbDQH8ks5sV0QVgaJpZM4OjHFO>
> .
>
> [C++] Cache timezone information in the library.
> ------------------------------------------------
>
> Key: ORC-218
> URL: https://issues.apache.org/jira/browse/ORC-218
> Project: ORC
> Issue Type: Improvement
> Reporter: Martin Grund
>
> Right now, for every lookup of a timezone, the library will go to disk and
> parse the timezone file. While the results are cached, doing these system
> calls should be avoided in environments with restricted system calls.
> I prepared a patch that will at build time load all the time zone files into
> the binary and instead of accessing disk for the TZ information will simply
> load the buffer from memory. In addition this allows the user to compile the
> library with a static timezone to be assumed for local use. This comes in
> handy to avoid yet another set of system calls to assume the local timezone.
> The feature can be controlled using the following CMake flags
> * NO_EMBEDED_TZ_DB - to turn it off, by default is on
> * STATIC_TZ=VAL - where val is a name of a timezone.
> I'll create a PR for code-review.
> Would be great if you could consider this patch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
