[
https://issues.apache.org/jira/browse/ORC-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122027#comment-16122027
]
ASF GitHub Bot commented on ORC-227:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/152#discussion_r132529457
--- Diff: c++/src/ByteRLE.cc ---
@@ -26,9 +26,9 @@
namespace orc {
- const size_t MINIMUM_REPEAT = 3;
- const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
- const size_t MAX_LITERAL_SIZE = 128;
+ const int MINIMUM_REPEAT = 3;
+ const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
+ const int MAX_LITERAL_SIZE = 128;
--- End diff --
I tried CentOS6 docker image. The warnings seem to be correct.
```
cc1plus: warnings being treated as errors
/root/orc/c++/src/ByteRLE.cc: In member function ‘void
orc::ByteRleEncoderImpl::write(char)’:
/root/orc/c++/src/ByteRLE.cc:152: error: comparison between signed and
unsigned integer expressions
/root/orc/c++/src/ByteRLE.cc:166: error: comparison between signed and
unsigned integer expressions
/root/orc/c++/src/ByteRLE.cc:167: error: comparison between signed and
unsigned integer expressions
/root/orc/c++/src/ByteRLE.cc:179: error: comparison between signed and
unsigned integer expressions
make[2]: *** [c++/src/CMakeFiles/orc.dir/ByteRLE.cc.o] Error 1
make[1]: *** [c++/src/CMakeFiles/orc.dir/all] Error 2
```
> [C++] Fix docker failure due to ExternalProject_Add
> ---------------------------------------------------
>
> Key: ORC-227
> URL: https://issues.apache.org/jira/browse/ORC-227
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
> Fix For: 1.5.0
>
>
> Docker builds are currently failing due to ExternalProject changes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
