ASF GitHub Bot commented on ORC-228:

GitHub user ekoifman opened a pull request:


    ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ekoifman/orc ORC-228

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #154
commit ac56bacb0f58c5703cb7fb55ef8b70b7a08cd8a3
Author: Eugene Koifman <ekoif...@hortonworks.com>
Date:   2017-08-11T23:58:10Z

    ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable


> Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS configurable
> -------------------------------------------------------
>                 Key: ORC-228
>                 URL: https://issues.apache.org/jira/browse/ORC-228
>             Project: ORC
>          Issue Type: Improvement
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
> currently addedRow() looks like
> {noformat}
> public void addedRow(int rows) throws IOException {
>     rowsAddedSinceCheck += rows;
>     if (rowsAddedSinceCheck >= ROWS_BETWEEN_CHECKS) {
>       notifyWriters();
>     }
>   }
> {noformat}
> it would be convenient for testing to set ROWS_BETWEEN_CHECKS to a low value 
> so that we can generate multiple stripes with very little data.
> Currently the only way to do this is to create a new MemoryManager that 
> overrides this method and install it via OrcFile.WriterOptions but this only 
> works when you have control over creating the Writer.
> For example 
> _org.apache.hadoop.hive.ql.io.orc.TestOrcRawRecordMerger.testRecordReaderNewBaseAndDelta()_
> There is no way to do this via some set of config params to make Hive query 
> for example, create multiple stripes with little data.

This message was sent by Atlassian JIRA

Reply via email to