[
https://issues.apache.org/jira/browse/ORC-224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137646#comment-16137646
]
ASF GitHub Bot commented on ORC-224:
------------------------------------
Github user wgtmac commented on a diff in the pull request:
https://github.com/apache/orc/pull/149#discussion_r134630866
--- Diff: c++/test/TestWriter.cc ---
@@ -209,5 +209,612 @@ namespace orc {
}
EXPECT_FALSE(rowReader->next(*batch));
}
-}
+ TEST(Writer, writeStringAndBinaryColumn) {
--- End diff --
It is better to keep them in different test cases for following reasons:
1. It seems that they share the same logic in testing but they differ in
the data construction and verification parts for different types. It has the
same rationale with the design of ColumnWriter classes.
2. We may have different design/implementations for some types in the
future. It is much easier to test them if we de-couple them into separate tests.
> Implement column writers of primitive types
> -------------------------------------------
>
> Key: ORC-224
> URL: https://issues.apache.org/jira/browse/ORC-224
> Project: ORC
> Issue Type: Sub-task
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
>
> As ORC-178 has implemented basic column writers for integers. This JIRA is
> targeted at implementing ColumnWriters of remaining primitive types including
> float, double, string, binary, etc.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
