[ 
https://issues.apache.org/jira/browse/ORC-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16206561#comment-16206561
 ] 

Sandeep More commented on ORC-252:
----------------------------------

Hello Owen,

The PR looks great ! learned a lot and liked the getLocalKey() idea. 
I have few question though mostly around the implementation.

1. Will  we  be only supporting AES-CTR ? any plans for adding support to 
others such as AES-GCM
2. Looking at the KeyTool class:
   2.1 It appears that the printKey function will always print a 
different/unique key ? (I am going by the javadocs)
   2.2 Do we need to print the key material to system out - unless it will be 
consumed by other clients

> Add support for Key Management Servers (kms) to HadoopShims
> -----------------------------------------------------------
>
>                 Key: ORC-252
>                 URL: https://issues.apache.org/jira/browse/ORC-252
>             Project: ORC
>          Issue Type: Sub-task
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to