[ 
https://issues.apache.org/jira/browse/ORC-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16221147#comment-16221147
 ] 

Sandeep More edited comment on ORC-256 at 10/26/17 8:21 PM:
------------------------------------------------------------

I was going through the DecimalRedactConverter class in RedactMaskFactory, it 
appears that we are not using maskDecimal() function on line #361, perhaps a 
bug ?
{code}
if (original.isRepeating) {
        target.isNull[0] = source.isNull[0];
        if (target.noNulls || !target.isNull[0]) {
          target.vector[0].set(maskDecimal(source.vector[0]));
        }
      } else {
        for(int r = start; r < start + length; ++r) {
          target.isNull[r] = source.isNull[r];
          if (target.noNulls || !target.isNull[r]) {
            target.vector[r].set(source.vector[r]);  //#361
          }
{code}


was (Author: smore):
I was going through the DecimalRedactConverter class in RedactMaskFactory, it 
appears that we are not using maskDecimal() function on line #361
{code}
if (original.isRepeating) {
        target.isNull[0] = source.isNull[0];
        if (target.noNulls || !target.isNull[0]) {
          target.vector[0].set(maskDecimal(source.vector[0]));
        }
      } else {
        for(int r = start; r < start + length; ++r) {
          target.isNull[r] = source.isNull[r];
          if (target.noNulls || !target.isNull[r]) {
            target.vector[r].set(source.vector[r]);  //#361
          }
{code}

> Add unmasked ranges option for redact mask
> ------------------------------------------
>
>                 Key: ORC-256
>                 URL: https://issues.apache.org/jira/browse/ORC-256
>             Project: ORC
>          Issue Type: Sub-task
>            Reporter: Owen O'Malley
>            Assignee: Sandeep More
>
> It would be good to extend the Redact DataMask so that you could leave 
> certain ranges of strings unmasked.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to