[
https://issues.apache.org/jira/browse/ORC-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234860#comment-16234860
]
ASF GitHub Bot commented on ORC-261:
------------------------------------
GitHub user jcrist opened a pull request:
https://github.com/apache/orc/pull/185
ORC-261: [C++] Fix installation to include all header files
Addresses [issue
261](https://issues.apache.org/jira/projects/ORC/issues/ORC-261).
- Fixes installation to include all necessary header files in `include/orc`
- Removes a few unnecessary includes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcrist/orc fix-install-includes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #185
----
commit 92200217641d645cd382f0cab5c8ffc33e62e5b7
Author: Jim Crist <[email protected]>
Date: 2017-11-01T22:20:00Z
Fix installation to include all header files
- Fixes installation to include all necessary header files in
`include/orc`
- Removes a few unnecessary includes
----
> All necessary c++ headers not included in install
> -------------------------------------------------
>
> Key: ORC-261
> URL: https://issues.apache.org/jira/browse/ORC-261
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: Jim Crist
> Priority: Normal
>
> When installing the c++ library, all necessary headers aren't included in the
> installed `include` directory. This complicates using the library in external
> projects.
> `orc/Common.hh` includes `Exceptions.hh`, which is in the `src` directory.
> This in turn includes the generated `Adaptor.hh` header, also in the `src`
> directory.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
