[
https://issues.apache.org/jira/browse/ORC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237098#comment-16237098
]
ASF GitHub Bot commented on ORC-187:
------------------------------------
GitHub user rajeshbalamohan opened a pull request:
https://github.com/apache/orc/pull/186
ORC-187: BitFieldReader has an unnecessary loop
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajeshbalamohan/orc ORC-187
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/186.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #186
----
commit 2c91d132a0e66bfa4cf7c95ab20f2de7a6326ff0
Author: Rajesh Balamohan <[email protected]>
Date: 2017-11-03T04:58:28Z
ORC-187: BitFieldReader has an unnecessary loop
----
> BitFieldReader has an unnecessary loop
> --------------------------------------
>
> Key: ORC-187
> URL: https://issues.apache.org/jira/browse/ORC-187
> Project: ORC
> Issue Type: Bug
> Components: Java, Reader
> Affects Versions: 1.4.0
> Reporter: Gopal V
> Priority: Major
> Attachments: perf-top-bitReader-asm.png, perf-top-bitReader.png
>
>
> {code}
> /** The number of bits in one item. Non-test code always uses 1. */
> private final int bitSize;
> {code}
> The bitField reader was originally supposed to be extensible as an Integer
> reader with packing - but HIVE-7219 introduced parallel unpack routines which
> were better.
> This makes BitFieldReader::next() the core hotspot for integer sequences.
> !perf-top-bitReader.png!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
