[
https://issues.apache.org/jira/browse/ORC-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242603#comment-16242603
]
ASF GitHub Bot commented on ORC-187:
------------------------------------
Github user omalley commented on the issue:
https://github.com/apache/orc/pull/186
Since this is removing the old functionality, you should remove the old
constructor that takes the bitWidth. With this change, someone who passed in a
non-one width would be surprised with the result.
> Simplify BitFieldReader to only support single bits
> ---------------------------------------------------
>
> Key: ORC-187
> URL: https://issues.apache.org/jira/browse/ORC-187
> Project: ORC
> Issue Type: Bug
> Components: Java, Reader
> Affects Versions: 1.4.0
> Reporter: Gopal V
> Assignee: Rajesh Balamohan
> Attachments: perf-top-bitReader-asm.png, perf-top-bitReader.png,
> perf_asm.png, perf_latest_patch.png, perf_with_fix.png
>
>
> {code}
> /** The number of bits in one item. Non-test code always uses 1. */
> private final int bitSize;
> {code}
> The bitField reader was originally supposed to be extensible as an Integer
> reader with packing - but HIVE-7219 introduced parallel unpack routines which
> were better.
> This makes BitFieldReader::next() the core hotspot for integer sequences.
> !perf-top-bitReader.png!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
