[
https://issues.apache.org/jira/browse/ORC-283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299975#comment-16299975
]
ASF GitHub Bot commented on ORC-283:
------------------------------------
Github user majetideepak commented on a diff in the pull request:
https://github.com/apache/orc/pull/204#discussion_r158269151
--- Diff: cmake_modules/FindGTest.cmake ---
@@ -28,7 +28,7 @@ find_path (GTEST_INCLUDE_DIR gmock/gmock.h HINTS
NO_DEFAULT_PATH
PATH_SUFFIXES "include")
-find_library (GTEST_LIBRARIES NAMES gmock PATHS
+find_library (GTEST_LIBRARIES NAMES gmock HINTS
--- End diff --
`HINTS` is apt here. `PATHS` must only be used for hardcoded guesses.
https://cmake.org/cmake/help/v3.0/command/find_library.html
> Enable the cmake build to pick specified libraries over the default libraries
> -----------------------------------------------------------------------------
>
> Key: ORC-283
> URL: https://issues.apache.org/jira/browse/ORC-283
> Project: ORC
> Issue Type: Bug
> Reporter: Deepak Majeti
> Assignee: Deepak Majeti
>
> The changes in https://github.com/apache/orc/pull/194 are causing libraries
> in the default path to be picked over the specified path.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
