[ https://issues.apache.org/jira/browse/ORC-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366103#comment-16366103 ]
ASF GitHub Bot commented on ORC-301: ------------------------------------ Github user prasanthj commented on a diff in the pull request: https://github.com/apache/orc/pull/218#discussion_r168572505 --- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java --- @@ -516,12 +516,13 @@ OrcTail buildEmptyTail() { protected OrcTail extractFileTail(FileSystem fs, Path path, long maxFileLength) throws IOException { - FSDataInputStream file = fs.open(path); + FSDataInputStream file = null; ByteBuffer buffer; OrcProto.PostScript ps; OrcProto.FileTail.Builder fileTailBuilder = OrcProto.FileTail.newBuilder(); long modificationTime; try { --- End diff -- Line 610 doesn't add much value as close() will throw IOException anyway which should be sufficient to know the reason. > `extractFileTail` should open a file in `try` statement > ------------------------------------------------------- > > Key: ORC-301 > URL: https://issues.apache.org/jira/browse/ORC-301 > Project: ORC > Issue Type: Bug > Components: Java > Affects Versions: 1.4.1 > Reporter: Dongjoon Hyun > Priority: Major > > To prevent opened file leakage, we need to move the file open position. > {code} > --- a/java/core/src/java/org/apache/orc/impl/ReaderImpl.java > long maxFileLength) throws IOException { > - FSDataInputStream file = fs.open(path); > + FSDataInputStream file = null; > ByteBuffer buffer; > OrcProto.PostScript ps; > OrcProto.FileTail.Builder fileTailBuilder = > OrcProto.FileTail.newBuilder(); > long modificationTime; > try { > + file = fs.open(path); > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)