[
https://issues.apache.org/jira/browse/ORC-310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382816#comment-16382816
]
ASF GitHub Bot commented on ORC-310:
------------------------------------
Github user omalley commented on a diff in the pull request:
https://github.com/apache/orc/pull/222#discussion_r171720713
--- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java ---
@@ -472,8 +473,9 @@ public static OrcTail extractFileTail(ByteBuffer
buffer, long fileLength, long m
.setPostscript(ps)
.setFooter(footer)
.setFileLength(fileLength);
+ isCodecError = false;
} finally {
--- End diff --
try {} finally is pretty broken. You are better off using the
try-with-resources statement.
> better error handling for codec
> -------------------------------
>
> Key: ORC-310
> URL: https://issues.apache.org/jira/browse/ORC-310
> Project: ORC
> Issue Type: Bug
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
