[ 
https://issues.apache.org/jira/browse/ORC-311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383673#comment-16383673
 ] 

ASF GitHub Bot commented on ORC-311:
------------------------------------

GitHub user stiga-huang opened a pull request:

    https://github.com/apache/orc/pull/223

    ORC-311: Fix null points when StripeFooter corrupts

    The c++ codes do not check streams got from the 
StripeStreamsImpl::getStream. It may return null pointers for corrupt 
StripeFooter, which crash the c++ Reader finally.
    
    Test files are attached to the JIRA.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/stiga-huang/orc check-streams

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/223.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #223
    
----
commit 6c21d6ee280106eab8e055af775a581e9d8ee7dc
Author: stiga-huang <huangquanlong@...>
Date:   2018-03-02T14:53:44Z

    Fix null points when StripeFooter corrupts

----


> C++ Reader crash for corrupt StripeFooter
> -----------------------------------------
>
>                 Key: ORC-311
>                 URL: https://issues.apache.org/jira/browse/ORC-311
>             Project: ORC
>          Issue Type: Bug
>          Components: C++
>    Affects Versions: 1.0.0, 1.1.2, 1.2.3, 1.3.4, 1.4.3
>            Reporter: Quanlong Huang
>            Priority: Major
>         Attachments: corrupt.orc, origin.orc
>
>
> The c++ codes do not check streams got from the StripeStreamsImpl::getStream. 
> It may return null pointers for corrupt StripeFooter, which crash the c++ 
> Reader finally.
> Two files are attached: one is normal, the other is corrupt from it and will 
> crash the c++ reader.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to