[ 
https://issues.apache.org/jira/browse/ORC-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383987#comment-16383987
 ] 

Owen O'Malley commented on ORC-309:
-----------------------------------

[~ekoifman] can you make a pull request for this? Thanks!

> WriterImpl.close() calls WriterCallback methods out of order
> ------------------------------------------------------------
>
>                 Key: ORC-309
>                 URL: https://issues.apache.org/jira/browse/ORC-309
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Eugene Koifman
>            Priority: Major
>
> }}org.apache.orc.impl.WriterImpl}}
> {noformat}
>   @Override
>   public void close() throws IOException {
>     if (callback != null) {
>       callback.preFooterWrite(callbackContext);
>     }
>     // remove us from the memory manager so that we don't get any callbacks
>     memoryManager.removeWriter(path);
>     // actually close the file
>     flushStripe();
>     lastFlushOffset = writeFooter();
>     physicalWriter.close();
>   }
>  {noformat}
> so this causes preFooterWrite() to be called before {{preStripeWrite()}} from 
> {{flushStripe()}}.
> HIVE-18817 is one place where this shows up



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to