[
https://issues.apache.org/jira/browse/ORC-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16524957#comment-16524957
]
ASF GitHub Bot commented on ORC-384:
------------------------------------
GitHub user martinrupp opened a pull request:
https://github.com/apache/orc/pull/289
ORC-384 fix memory leak when loading non-ORC files
Change-Id: Ia32f687f12f66c26b807200f90dd7ddcc5f27f8d
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/martinrupp/orc ORC-384
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/289.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #289
----
commit 9c71c10a9ee6240854b3eeb9349ec77a9455d329
Author: Martin Rupp <martin.rupp01@...>
Date: 2018-06-27T11:56:37Z
ORC-384 fix memory leak when loading non-ORC files
Change-Id: Ia32f687f12f66c26b807200f90dd7ddcc5f27f8d
----
> C++ Reader leaks memory when reading a non-ORC file
> ---------------------------------------------------
>
> Key: ORC-384
> URL: https://issues.apache.org/jira/browse/ORC-384
> Project: ORC
> Issue Type: Bug
> Components: C++
> Affects Versions: 1.5.1
> Reporter: Martin Rupp
> Priority: Minor
> Labels: memleak
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> When opening a non-ORC file, the readPostscript/ensureOrcFooter function
> throw an error, leaving behind a new'd DataBuffer<char>.
> Solution is to replace with std::unique_ptr<DataBuffer<char>>.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
