[
https://issues.apache.org/jira/browse/ORC-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555223#comment-16555223
]
ASF GitHub Bot commented on ORC-388:
------------------------------------
Github user xndai commented on the issue:
https://github.com/apache/orc/pull/293
LGTM
> Fix isSafeSubtract to use logical operator instead of bit operator
> ------------------------------------------------------------------
>
> Key: ORC-388
> URL: https://issues.apache.org/jira/browse/ORC-388
> Project: ORC
> Issue Type: Bug
> Components: C++, Java
> Reporter: Gang Wu
> Assignee: Gang Wu
> Priority: Major
>
> Both Java and C++ code has misused bit operator in isSafeSubtract function.
> Although it works coincidently, we should change it to logical operator.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
