[ 
https://issues.apache.org/jira/browse/ORC-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572414#comment-16572414
 ] 

ASF GitHub Bot commented on ORC-203:
------------------------------------

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/299#discussion_r208392508
  
    --- Diff: java/core/src/java/org/apache/orc/StringColumnStatistics.java ---
    @@ -33,6 +33,20 @@
        */
       String getMaximum();
     
    +  /**
    +   * Get the string with
    +   * length = Min(StringStatisticsImpl.MAX_BYTES_RECORDED, getMinimum())
    +   * @return lower bound
    +   */
    +  String getLowerBound();
    +
    +  /**
    +   * Get the string with
    +   * length = Min(StringStatisticsImpl.MAX_BYTES_RECORDED, getMaximum())
    --- End diff --
    
    Same here.


> Modify the StringStatistics to trim minimum and maximum values
> --------------------------------------------------------------
>
>                 Key: ORC-203
>                 URL: https://issues.apache.org/jira/browse/ORC-203
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Sandeep More
>            Priority: Major
>
> Currently the StringStatistics will record the entire value for minimum or 
> maximum. It creates large protobuf objects and serves very little value. I 
> think we should trim long strings to 1024 characters and record the fact that 
> they were trimmed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to