[ 
https://issues.apache.org/jira/browse/ORC-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576106#comment-16576106
 ] 

ASF GitHub Bot commented on ORC-394:
------------------------------------

Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/300#discussion_r209222998
  
    --- Diff: c++/test/TestWriter.cc ---
    @@ -1170,5 +1170,52 @@ namespace orc {
         }
       }
     
    +  TEST_P(WriterTest, writeUserMetadata) {
    --- End diff --
    
    can you add the user metadata check to an existing test?


> [C++] Add addUserMetadata() function to C++ writer
> --------------------------------------------------
>
>                 Key: ORC-394
>                 URL: https://issues.apache.org/jira/browse/ORC-394
>             Project: ORC
>          Issue Type: New Feature
>            Reporter: Zherui Cao
>            Priority: Major
>
> addUserMetadata() already exist on java side
> I think implementing it on c++ side would be useful
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to