[
https://issues.apache.org/jira/browse/ORC-403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen O'Malley resolved ORC-403.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.5.3
1.6.0
I just committed this. Thanks, Quanlong!
> Should check offsets got from protobuf Objects
> ----------------------------------------------
>
> Key: ORC-403
> URL: https://issues.apache.org/jira/browse/ORC-403
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: Quanlong Huang
> Assignee: Quanlong Huang
> Priority: Major
> Fix For: 1.6.0, 1.5.3
>
> Attachments: bad_stripe_info.orc, copy7_000000_0
>
>
> A malformed ORC file may have a postscript length larger than the file size,
> which causes orc:: readPostscript to read unexpected data.
> {code:java}
> std::unique_ptr<proto::PostScript> postscript =
> std::unique_ptr<proto::PostScript>(new proto::PostScript());
> if (!postscript->ParseFromArray(ptr + readSize - 1 - postscriptSize,
> static_cast<int>(postscriptSize))) {
> throw ParseError("Failed to parse the postscript from " +
> stream->getName());
> }
> {code}
> We should make sure readSize - 1 - postscriptSize >= 0. Furthermore, we
> should check offsets and lengths got from protobuf Objects.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
