[
https://issues.apache.org/jira/browse/ORC-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654291#comment-16654291
]
ASF GitHub Bot commented on ORC-419:
------------------------------------
prasanthj commented on issue #322: ORC-419: Ensure to call `close` at
RecordReaderImpl constructor exception
URL: https://github.com/apache/orc/pull/322#issuecomment-430808462
@dongjoon-hyun I think the patch may need rebase. I am not sure why author
wasn't shown correctly. I reverted it for now. I am new to this github (orc
source moved to githox) based merging. If next time doesn't work correctly I
will commit the PR manually until I figure out how to do it correctly to retain
authorship.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Ensure to call `close` at RecordReaderImpl constructor exception
> ----------------------------------------------------------------
>
> Key: ORC-419
> URL: https://issues.apache.org/jira/browse/ORC-419
> Project: ORC
> Issue Type: Bug
> Components: Java
> Affects Versions: 1.5.0, 1.5.1, 1.5.2, 1.5.3
> Reporter: Dongjoon Hyun
> Priority: Critical
>
> Currently, there is no way to call `RecordReaderImpl.close` if
> `RecordReader.rows` fails at creating `RecordReaderImpl`. This issue aims to
> try to invoke `close` in the constructor in case of Exceptions.
> {code}
> @Override
> public RecordReader rows(Options options) throws IOException {
> LOG.info("Reading ORC rows from " + path + " with " + options);
> return new RecordReaderImpl(this, options);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
