[
https://issues.apache.org/jira/browse/ORC-421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657705#comment-16657705
]
ASF GitHub Bot commented on ORC-421:
------------------------------------
omalley commented on issue #327: ORC-421: Separate compression options from the
CompressionCodec.
URL: https://github.com/apache/orc/pull/327#issuecomment-431546294
Basically, this patch does:
- Makes CompressionCodec.Option that controls compression options
- CompressionCodec.compress takes a CompressionCodec.Option
- Removes CompressionCodec.modify so that we don't clone the codec via modify
- Makes the StreamOptions.withCodec take a CompressionCodec.Option object
- Fix all of the callers to use the OutStream constructor that takes the
StreamOptions.
- WriterImpl.getCustomizedCodec now returns a CompressionCodec.Option
instead of a CompressionCodec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Separate the compression options from the CompressionCodec
> ----------------------------------------------------------
>
> Key: ORC-421
> URL: https://issues.apache.org/jira/browse/ORC-421
> Project: ORC
> Issue Type: Sub-task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Priority: Major
>
> Right now we embed the compression options in the codec and modify them by
> creating new CompressionCodecs. If we make the CompressionCodecs so that we
> can keep the Codec the same for the entire file and have different options
> that are passed in to CompressionCodec.compress(), we'll have fewer issues.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
