[
https://issues.apache.org/jira/browse/ORC-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670837#comment-16670837
]
ASF GitHub Bot commented on ORC-428:
------------------------------------
fangzheng commented on issue #331: ORC-428: Use ORC_UNIQUE_PTR consistently in
OrcFile, OrcHdfsFile and …
URL: https://github.com/apache/orc/pull/331#issuecomment-434867689
I am cancelling this PR, as Gang and Owen explained how the macro and
unique_ptr is handled in the dev mailing list
(https://mail-archives.apache.org/mod_mbox/orc-dev/201810.mbox/%3cCAHfHakEanDzf=03fcpyxnqfanebr9xqz-5zfwod9vyk_vvb...@mail.gmail.com%3e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer
> -------------------------------------------------------------------
>
> Key: ORC-428
> URL: https://issues.apache.org/jira/browse/ORC-428
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: Fang Zheng
> Priority: Minor
>
> In OrcFile.hh, the declarations of readLocalFile() and other four functions
> return ORC_UNIQUE_PTR:
> ORC_UNIQUE_PTR<InputStream> readLocalFile(const std::string& path);
> ORC_UNIQUE_PTR<InputStream> readHdfsFile(const std::string& path);
> ORC_UNIQUE_PTR<Reader> createReader(ORC_UNIQUE_PTR<InputStream> stream,
> const ReaderOptions& options);
> ORC_UNIQUE_PTR<Writer> createWriter(const Type& type, OutputStream* stream,
> const WriterOptions& options);
> However, these functions' definitions all return std::unique_ptr. On a system
> where ORC_UNIQUE_PTR is not defined as std::unique_ptr but std::auto_ptr,
> there is inconsistency.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
