[
https://issues.apache.org/jira/browse/ORC-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fang Zheng closed ORC-428.
--------------------------
Resolution: Not A Problem
Gang and Own explained how the macro and unique_ptr is handled in the dev
mailing list:
https://mail-archives.apache.org/mod_mbox/orc-dev/201810.mbox/%3cCAHfHakEanDzf=03fcpyxnqfanebr9xqz-5zfwod9vyk_vvb...@mail.gmail.com%3e
> Use ORC_UNIQUE_PTR consistently in OrcFile, OrcHdfsFile, and Writer
> -------------------------------------------------------------------
>
> Key: ORC-428
> URL: https://issues.apache.org/jira/browse/ORC-428
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: Fang Zheng
> Priority: Minor
>
> In OrcFile.hh, the declarations of readLocalFile() and other four functions
> return ORC_UNIQUE_PTR:
> ORC_UNIQUE_PTR<InputStream> readLocalFile(const std::string& path);
> ORC_UNIQUE_PTR<InputStream> readHdfsFile(const std::string& path);
> ORC_UNIQUE_PTR<Reader> createReader(ORC_UNIQUE_PTR<InputStream> stream,
> const ReaderOptions& options);
> ORC_UNIQUE_PTR<Writer> createWriter(const Type& type, OutputStream* stream,
> const WriterOptions& options);
> However, these functions' definitions all return std::unique_ptr. On a system
> where ORC_UNIQUE_PTR is not defined as std::unique_ptr but std::auto_ptr,
> there is inconsistency.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
