[ 
https://issues.apache.org/jira/browse/ORC-418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671822#comment-16671822
 ] 

ASF GitHub Bot commented on ORC-418:
------------------------------------

omalley commented on a change in pull request #328: ORC-418. Fix broken docker 
builds.
URL: https://github.com/apache/orc/pull/328#discussion_r230104600
 
 

 ##########
 File path: docker/centos6/Dockerfile
 ##########
 @@ -42,6 +43,22 @@ WORKDIR /root
 RUN wget 
"https://www.apache.org/dyn/closer.lua?action=download&filename=/maven/maven-3/3.3.9/binaries/apache-maven-3.3.9-bin.tar.gz";
 -O maven.tgz
 RUN tar xzf maven.tgz
 RUN ln -s /root/apache-maven-3.3.9/bin/mvn /usr/bin/mvn
+# install a local build of protobuf
+RUN wget "https://github.com/protocolbuffers/protobuf/archive/v2.5.0.tar.gz"; \
 
 Review comment:
   Dockerfiles by design aren't parameterized. They are designed to be concrete 
steps to build the image. On the plus side, the current linux distros don't 
need the legacy versions of protobuf or snappy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Fix broken centos6 compilation
> ------------------------------
>
>                 Key: ORC-418
>                 URL: https://issues.apache.org/jira/browse/ORC-418
>             Project: ORC
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 1.6.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>
> We've accidentally broken the centos 6 C++ build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to