[
https://issues.apache.org/jira/browse/ORC-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16672344#comment-16672344
]
ASF GitHub Bot commented on ORC-431:
------------------------------------
fangzheng opened a new pull request #334: ORC-431: [C++] Fix typo in exception
message and simplify code logic.
URL: https://github.com/apache/orc/pull/334
1. Fix typo in the exception message in WriterOptions::setFileVersion():
"Unpoorted" should be "Unsupported".
2. Simplify some code in Writer.cc and OutputStream.cc to avoid
re-computation.
3. Simplify a condition check in WriterImpl::buildFooterType().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix typo in exception message and simplify code logic
> -----------------------------------------------------
>
> Key: ORC-431
> URL: https://issues.apache.org/jira/browse/ORC-431
> Project: ORC
> Issue Type: Improvement
> Components: C++
> Reporter: Fang Zheng
> Priority: Minor
>
> 1. Fix typo in the exception message in WriterOptions::setFileVersion():
> "Unpoorted" should be "Unsupported".
> 2. Simplify some code in Writer.cc and OutputStream.cc to avoid
> re-computation.
> 3. Simplify a condition check in WriterImpl::buildFooterType().
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
