[ 
https://issues.apache.org/jira/browse/ORC-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929139#comment-16929139
 ] 

Laszlo Bodor commented on ORC-554:
----------------------------------

I'll leave this open for further investigation, it seems like the current logic 
can result in negative nanos, maybe it's a regression after ORC-531:
https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L1413

from a hive test
{code}
Caused by: java.io.IOException: java.time.DateTimeException: Invalid value for 
NanoOfSecond (valid values 0 - 999999999): -1000000
        at 
org.apache.hadoop.hive.io.HiveIOExceptionHandlerChain.handleRecordReaderNextException(HiveIOExceptionHandlerChain.java:121)
        at 
org.apache.hadoop.hive.io.HiveIOExceptionHandlerUtil.handleRecordReaderNextException(HiveIOExceptionHandlerUtil.java:77)
        at 
org.apache.hadoop.hive.ql.io.HiveContextAwareRecordReader.doNext(HiveContextAwareRecordReader.java:366)
        at 
org.apache.hadoop.hive.ql.io.HiveRecordReader.doNext(HiveRecordReader.java:79)
        at 
org.apache.hadoop.hive.ql.io.HiveRecordReader.doNext(HiveRecordReader.java:33)
        at 
org.apache.hadoop.hive.ql.io.HiveContextAwareRecordReader.next(HiveContextAwareRecordReader.java:116)
        at 
org.apache.hadoop.mapred.split.TezGroupedSplitsInputFormat$TezGroupedSplitsRecordReader.next(TezGroupedSplitsInputFormat.java:151)
        at 
org.apache.tez.mapreduce.lib.MRReaderMapred.next(MRReaderMapred.java:116)
        at 
org.apache.hadoop.hive.ql.exec.tez.MapRecordSource.pushRecord(MapRecordSource.java:68)
{code}

> Float to timestamp schema evolution handles time/nanoseconds incorrectly
> ------------------------------------------------------------------------
>
>                 Key: ORC-554
>                 URL: https://issues.apache.org/jira/browse/ORC-554
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Laszlo Bodor
>            Assignee: Laszlo Bodor
>            Priority: Major
>         Attachments: ORC-554.repro.patch
>
>
> During ORC-539 I found a reproducible issue:  [^ORC-554.repro.patch] 
> seems like float to timestamp schema evolution loses nanoseconds somewhere, 
> moreover, seconds are not correct in the result TimestampColumnVector
> https://issues.apache.org/jira/browse/ORC-539?focusedCommentId=16928308&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16928308



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

Reply via email to