[ 
https://issues.apache.org/jira/browse/ORC-564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16961485#comment-16961485
 ] 

Owen O'Malley commented on ORC-564:
-----------------------------------

Another approach would be to use a bind mount to get the ORC source root into 
the container.

The command would be:
{code}
CMD if [ ! -d orc ]; then \
      git clone https://github.com/apache/orc.git -b master; \
    fi && \
    mkdir build && \
    cd build && \
    cmake ../orc && \
    make package test-out
{code}

If you run the image as:
{code}
% docker run -v`pwd`:/root/orc orc-ubuntu18
{code}
it will bind the current working directory to /root/orc and then build from 
that. If the -v is not passed in, it will download from apache's master branch 
and build that.

Thoughts?

> fix Docker scripts so that their command is bash
> ------------------------------------------------
>
>                 Key: ORC-564
>                 URL: https://issues.apache.org/jira/browse/ORC-564
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently the Docker files all have run commands that download and build 
> master. That tends to confuse users who expect it to build and test their 
> download. Furthermore, the scripts got out of date, because they were 
> intended to be used with the scripts run-one.sh and run-all.sh, which 
> override the run command.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to