[
https://issues.apache.org/jira/browse/ORC-573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gang Wu updated ORC-573:
------------------------
Description:
Before implementing predicate pushdown for C++ ORC reader, there are some gaps
and the scope of this patch is to fix them.
Int128::toDecimalString() function has used wrong parameter in substr()
operations which could lead to wrong string representation of decimal values.
In addition, bloom filter and decimal column statistics store string
representation of decimal values. However, we should trim trailing zeros for
these string values. Otherwise, it is inconsistent with Java implementation and
hard to do bloom filter checking when decimal value has a different scale in
the predicate.
Lastly, we should support decimal comparison to simplify sargs implementation.
was:
Int128::toDecimalString() function has used wrong parameter in substr()
operations which could lead to wrong string representation of decimal values.
In addition,
> [C++] Fix several issues in Int128 and Decimal
> ----------------------------------------------
>
> Key: ORC-573
> URL: https://issues.apache.org/jira/browse/ORC-573
> Project: ORC
> Issue Type: Bug
> Components: C++
> Reporter: Gang Wu
> Assignee: Gang Wu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Before implementing predicate pushdown for C++ ORC reader, there are some
> gaps and the scope of this patch is to fix them.
> Int128::toDecimalString() function has used wrong parameter in substr()
> operations which could lead to wrong string representation of decimal values.
> In addition, bloom filter and decimal column statistics store string
> representation of decimal values. However, we should trim trailing zeros for
> these string values. Otherwise, it is inconsistent with Java implementation
> and hard to do bloom filter checking when decimal value has a different scale
> in the predicate.
> Lastly, we should support decimal comparison to simplify sargs implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
