[
https://issues.apache.org/jira/browse/ORC-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042310#comment-17042310
]
Ramesh Kumar Thangarajan commented on ORC-595:
----------------------------------------------
[~pgaref] The decimal64 changes in the patch looks good to me. But is it
possible to create a separate patch for the version changes. I am not aware of
these version changes, so I am not confident enough to review them.
> Optimize Decimal64 scale calculation
> ------------------------------------
>
> Key: ORC-595
> URL: https://issues.apache.org/jira/browse/ORC-595
> Project: ORC
> Issue Type: Improvement
> Components: encoding
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Critical
> Attachments: DecimalBench-Clean-scale2.log,
> DecimalBench-ORC-595-scale2.log, Profile-ORC-595-clean.png,
> Profile-ORC-595-patch.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently Decimal64 is using an inner loop to apply the correct scale to each
> read Long value
> [https://github.com/apache/orc/blob/master/java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java#L1294]
> A more efficient way would be to apply the scale using a single array access
> and by multiplying by 10 in the power of (scale - scratchScaleVector[r]).
> An extra optimization would be to keep all powers of 10 (up to 18) in a
> static array and reuse it across runtime instead of calculating each time.
> cc: [~rameshkumar] [~gopalv]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
