[ 
https://issues.apache.org/jira/browse/ORC-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256445#comment-17256445
 ] 

Panagiotis Garefalakis edited comment on ORC-709 at 12/30/20, 10:49 AM:
------------------------------------------------------------------------

This is now resolved via [https://github.com/apache/orc/pull/594]


was (Author: pgaref):
This is now resolved via [https://github.com/apache/orc/pull/594]
and [https://github.com/apache/orc/pull/595] for 1.6 branch

> FIX Boolean to StringGroup schema evolution
> -------------------------------------------
>
>                 Key: ORC-709
>                 URL: https://issues.apache.org/jira/browse/ORC-709
>             Project: ORC
>          Issue Type: Bug
>          Components: evolution, Reader
>    Affects Versions: 1.6.6, 1.7.0
>            Reporter: Panagiotis Garefalakis
>            Assignee: Panagiotis Garefalakis
>            Priority: Major
>             Fix For: 1.7.0, 1.6.7
>
>
> Even though Boolean to String/Char/Varchar conversion needs special handling 
> (explicitly converting 1s to 'TRUE's and 0s to 'FALSE's) we are currently 
> using the same logic for all numeric vectors 
> (StringGroupFromAnyIntegerTreeReader).
> [StringGroupFromBooleanTreeReader|https://github.com/apache/orc/blob/48cba3bafa7ef31f162f8c377d513f1c58a27876/java/core/src/java/org/apache/orc/impl/ConvertTreeReaderFactory.java#L1052]
>  logic is there but seems broken since ORC-531 refactor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to