[
https://issues.apache.org/jira/browse/ORC-992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17414733#comment-17414733
]
Dongjoon Hyun commented on ORC-992:
-----------------------------------
Hi, [~Guiyankuang]. Thank you always for your contribution. There is some tips
to you for filing a JIRA. :)
1. `Fix Version` should be empty. That will be filled by the committer when
this PR is resolved by merging.
2. For `Improvement` type issue, the `Affected Version` should be the `main`
branch version which is `1.8.0-SNAPSHOT` as of today.
> Reached max repeat length, we can directly decide to use DELTA encoding
> -----------------------------------------------------------------------
>
> Key: ORC-992
> URL: https://issues.apache.org/jira/browse/ORC-992
> Project: ORC
> Issue Type: Improvement
> Components: Java
> Affects Versions: 1.7.0
> Reporter: Yiqun Zhang
> Priority: Minor
> Fix For: 1.7.0
>
>
> Reached max repeat length, we can directly decide to use DELTA encoding.
> RunLengthIntegerWriterV2.java 756-760
> {code:java}
> // if fixed runs reached max repeat length then write values
> if (fixedRunLength == MAX_SCOPE) {
> determineEncoding();
> writeValues();
> }
> {code}
> If fixed runs reached max repeat length. We have been able to determine the
> use of the DELTA code, fixedDelta is zero.
> The computeZigZagLiterals, zzBits100p, and determine isFixedDelta within the
> determineEncoding method are all redundant in the current case.
> Similar practices.
> RunLengthIntegerWriterV2.java 767-775
> {code:java}
> if (fixedRunLength >= MIN_REPEAT) {
> if (fixedRunLength <= MAX_SHORT_REPEAT_LENGTH) {
> encoding = EncodingType.SHORT_REPEAT;
> } else {
> encoding = EncodingType.DELTA;
> isFixedDelta = true;
> }
> writeValues();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
