dongjoon-hyun commented on code in PR #1114:
URL: https://github.com/apache/orc/pull/1114#discussion_r870900536
##########
c++/src/Reader.hh:
##########
@@ -187,6 +188,16 @@ namespace orc {
friend class TestRowReader_advanceToNextRowGroup_Test;
friend class TestRowReader_computeBatchSize_Test;
+ inline uint64_t lastRowOfCurrentStripe() const {
Review Comment:
Please add a function description comment.
##########
c++/src/Reader.hh:
##########
@@ -187,6 +188,16 @@ namespace orc {
friend class TestRowReader_advanceToNextRowGroup_Test;
friend class TestRowReader_computeBatchSize_Test;
+ inline uint64_t lastRowOfCurrentStripe() const {
+ return currentStripe < lastStripe ?
+ firstRowOfStripe[currentStripe] + rowsInCurrentStripe :
+ footer->numberofrows();
+ }
+
+ inline bool isCurrentStripeInited() const {
Review Comment:
Please add a function description comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
