guiyanakuang commented on code in PR #1118:
URL: https://github.com/apache/orc/pull/1118#discussion_r874402786
##########
java/core/src/java/org/apache/orc/OrcConf.java:
##########
@@ -206,7 +206,9 @@ public enum OrcConf {
"orc.proleptic.gregorian.default", false,
"This value controls whether pre-ORC 27 files are using the hybrid or
proleptic\n" +
"calendar. Only Hive 3.1 and the C++ library wrote using the proleptic,
so hybrid\n" +
- "is the default.")
+ "is the default."),
+ STRIPE_ROW_COUNT("orc.stripe.row.count","hive.exec.orc.stripe.row.count",
Review Comment:
If hive doesn't have this configuration, to avoid being misleading, I think
we should set hiveConfName to be the same as attribute.
##########
java/core/src/java/org/apache/orc/impl/WriterImpl.java:
##########
@@ -300,7 +302,7 @@ private boolean checkMemory() throws IOException {
LOG.debug("ORC writer " + physicalWriter + " size = " + size +
" limit = " + memoryLimit);
}
- if (size > memoryLimit) {
+ if (size > memoryLimit || rowsInStripe> stripeRowCount) {
Review Comment:
The frequency of this check is influenced by `OrcConf.ROWS_BETWEEN_CHECKS`,
we should compare the value of `stripeRowCount` with
`OrcConf.ROWS_BETWEEN_CHECKS` before using `stripeRowCount`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
