dongjoon-hyun commented on code in PR #1141:
URL: https://github.com/apache/orc/pull/1141#discussion_r882325625
##########
java/bench/core/src/java/org/apache/orc/bench/core/Driver.java:
##########
@@ -32,8 +34,14 @@ public class Driver {
private static Map<String, OrcBenchmark> getBenchmarks() {
Map<String, OrcBenchmark> result = new TreeMap<>();
- for(OrcBenchmark bench: loader) {
- result.put(bench.getName(), bench);
+ Iterator<OrcBenchmark> iterator = loader.iterator();
+ while (iterator.hasNext()) {
+ try {
+ OrcBenchmark bench = iterator.next();
+ result.put(bench.getName(), bench);
+ } catch (ServiceConfigurationError e) {
+ System.out.println("WARN (Driver): misconfigured benchmark exists:" +
e);
Review Comment:
Shall we use `System.err`?
```java
System.out.println("WARN (Driver): misconfigured benchmark exists:" + e);
System.err.println("Misconfigured benchmark exists:" + e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
