mwlon opened a new pull request, #1142:
URL: https://github.com/apache/orc/pull/1142

   ### What changes were proposed in this pull request?
   Make docs and gitignore a bit more helpful for benchmark suite
   
   ### Why are the changes needed?
   * Benchmark `generate` command should not refer to itself as `convert`:
   ```$ java -jar core/target/orc-benchmarks-core-*-uber.jar generate data 
--help
   usage: convert <root>
    -c,--compress <arg>   List of compression
    -d,--data <arg>       List of data sets
    -f,--format <arg>     List of formats
    -h,--help             Provide help
    -s,--sales <arg>      Number of records for sales```
    * README command for packaging the benchmark suite currently runs all 
tests; usually this is not necessary
    * benchmark generated data should be in .gitignore so that they are not 
accidentally added to git history
   
   ### How was this patch tested?
   No functionality or tests were modified
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to