coderex2522 commented on code in PR #1271: URL: https://github.com/apache/orc/pull/1271#discussion_r990744453
########## c++/src/BlockBuffer.cc: ########## @@ -0,0 +1,85 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "BlockBuffer.hh" + +#include <algorithm> + +namespace orc { + + BlockBuffer::BlockBuffer(MemoryPool& pool, uint64_t _blockSize) + : memoryPool(pool), + currentSize(0), + currentCapacity(0), + blockSize(_blockSize) { + if (blockSize == 0) { + throw std::logic_error("Block size cannot be zero"); + } + reserve(blockSize); + } + + BlockBuffer::~BlockBuffer() { + for (size_t i = 0; i < blocks.size(); ++i) { + memoryPool.free(blocks[i]); + } + blocks.clear(); + currentSize = currentCapacity = 0; + } + + BlockBuffer::Block BlockBuffer::getBlock(uint64_t blockIndex) const { + if (blockIndex >= getBlockNumber()) { + throw std::out_of_range("Block index out of range"); + } + return Block(blocks[blockIndex], + std::min(currentSize - blockIndex * blockSize, blockSize)); + } + + BlockBuffer::Block BlockBuffer::getNextBlock() { + if (currentSize < currentCapacity) { + Block emptyBlock( + blocks[currentSize / blockSize] + currentSize % blockSize, + blockSize - currentSize % blockSize); + currentSize = (currentSize / blockSize + 1) * blockSize; Review Comment: Since the flush() function of class BufferedOutputStream needs to access all allocated memory blocks, it needs class BlockBuffer to provide an interface in order for BufferedOutputStream to access all allocated memory blocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
