deshanxiao opened a new pull request, #1286:
URL: https://github.com/apache/orc/pull/1286

   ### What changes were proposed in this pull request?
   This PR aims to fix build error when skip tests build. It has two 
modifications:
   - Add `ignoreNonCompile` in maven-dependency-plugin to skip all 
Runtime/Provided/Test/System scope dependency checking.
   - change slf4j-api scope to test.
   
   ### Why are the changes needed?
   The root cause of building failed is that -Dmaven.test.skip=true does not 
compile the test classes.
   Apache Maven Dependency Plugin will throw an error if a dependency is not 
used. We can use ignoreNonCompile defined in 
https://maven.apache.org/plugins/maven-dependency-plugin/analyze-only-mojo.html#ignoreNonCompile
 to avoid the problem.
   
   After adding this tag, I found that we have some classes such as slf4j-api 
in MapReduce module that only appear in test but scope is defined as compile. I 
adjusted its scope to test.
   
   For a related discussion, see https://github.com/apache/orc/issues/1277
   
   ### How was this patch tested?
   UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to