coderex2522 commented on code in PR #1275:
URL: https://github.com/apache/orc/pull/1275#discussion_r1002666732
##########
c++/src/Compression.cc:
##########
@@ -112,7 +118,10 @@ namespace orc {
bufferSize(0),
outputPosition(0),
outputSize(0) {
- // PASS
+ // init header pointer array
+ for (int i = 0; i < HEADER_SIZE; ++i) {
Review Comment:
use array.fill() function to initial the header array here.
##########
c++/src/Compression.cc:
##########
@@ -93,6 +95,10 @@ namespace orc {
// Compress output buffer size
int outputSize;
+
+ // Compression block header pointer array
+ static const int HEADER_SIZE = 3;
+ char* header[HEADER_SIZE];
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
